Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove method calls from chat endpoints (server) #35069

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

refactor: remove method calls from chat endpoints (server) #35069

wants to merge 12 commits into from
+272 −220

Conversation

MarcosSpessatto
Copy link
Member

https://rocketchat.atlassian.net/browse/CORE-963

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@MarcosSpessatto MarcosSpessatto added this to the 7.4.0 milestone Jan 30, 2025
@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 30, 2025 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: edc57b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35069/

Built to branch gh-pages at 2025-03-07 13:03 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.42%. Comparing base (d6a8fad) to head (edc57b8).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35069      +/-   ##
===========================================
- Coverage    59.46%   59.42%   -0.05%     
===========================================
  Files         2830     2829       -1     
  Lines        68512    68201     -311     
  Branches     15163    15097      -66     
===========================================
- Hits         40744    40530     -214     
+ Misses       25107    25028      -79     
+ Partials      2661     2643      -18
Flag Coverage Δ
unit 75.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review February 7, 2025 11:41
@MarcosSpessatto MarcosSpessatto requested a review from a team as a code owner February 7, 2025 11:41
sampaiodiego
sampaiodiego previously approved these changes Feb 13, 2025
View reviewed changes
@MarcosSpessatto MarcosSpessatto modified the milestones: 7.4.0, 7.5.0 Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcosSpessatto @sampaiodiego